Skip to content

Log filtered command name#1631

Merged
sijis merged 4 commits intoerrbotio:masterfrom
jcfrt:fix_cmdfilter_log
May 1, 2026
Merged

Log filtered command name#1631
sijis merged 4 commits intoerrbotio:masterfrom
jcfrt:fix_cmdfilter_log

Conversation

@jcfrt
Copy link
Copy Markdown
Contributor

@jcfrt jcfrt commented Feb 10, 2023 •
edited
Loading

If a command is blocked by a cmdfilter, the name of the command should be logged instead of being logged as "None".

@sijis sijis closed this Jun 10, 2023
@sijis sijis reopened this Jun 10, 2023
jcfrt and others added 4 commits April 30, 2026 21:06
@jcfrt @sijis
Log filtered command name
cb29827 
If a command is blocked by a cmdfilter, the name of the command should
be logged instead of logged as "None".
@jcfrt @sijis
Update cmdfilter docstring
7d98c99 
Returning cmd and args is not used by anything but for logging purposes.
@sijis
test: add tests to validate logging of cmdfilter
eea7118
@sijis
docs: add info to CHANGES
bca954a
@sijis sijis force-pushed the fix_cmdfilter_log branch from cb9d0ae to bca954a Compare May 1, 2026 02:26
@sijis
Copy link
Copy Markdown
Contributor

sijis commented May 1, 2026

@jcfrt Thank you!

@sijis
Copy link
Copy Markdown
Contributor

sijis commented May 1, 2026

As an example, this is what the before and after look like

## Before
  INFO:errbot.core:Command None blocked or deferred.
    returned tuple: (None, None, None)

## After
  INFO:errbot.core:Command "restart" blocked or deferred.
    returned tuple: (None, 'restart', ('--force',))

@sijis sijis merged commit 5632dbe into errbotio:master May 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcfrt @sijis